Re: [PATCH 1/2] SLUB: Fix merged slab cache names

From: Christoph Lameter
Date: Tue Sep 14 2010 - 14:00:00 EST


On Tue, 14 Sep 2010, Pekka Enberg wrote:

> > > Do you mean refcount == 2? You don't know during kmem cache release time
> > > if
> > > someone was merged to the cache or not.
> > > > Ok. Keeping the original name. Why dont we do strdup by default and
> > > > always
> > > > do a kfree(s->name) on close?
> > > >
> > > I tried that. It gets very nasty during bootstrap.
> > Add it only to kmem_cache_create() not to kmem_cache_open. That is not
> > used during bootstrap. The bootstrap caches do not matter since they are
> > never freed
> I tried that too. It doesn't work because we get merged to kmalloc caches and
> can't do kfree() on them.

For most of the kmalloc caches we are already doing a kasprintf. See the
last for loop in kmem_cache_init(). There are a couple of cases where we
are not doing it right now. kmalloc-96 kmalloc-192 and
kmem_cache_node.





--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/