Re: [PATCH] Fix hiddev's use of usb_find_interface

From: Jiri Kosina
Date: Tue Sep 14 2010 - 04:59:33 EST


On Mon, 13 Sep 2010, Guillaume Chazarain wrote:

> > Yeah -- Guillaume, I think that you are actually seeing symptoms of
> > intfdata being bogus. Could you please try with any kernel with commit
> > 9c9e54a8df0be48 ("HID: hiddev: fix memory corruption due to invalid
> > intfdata") applied (which is the one Arnd is talking about) and report
> > back whether the problem is fixed by it?
>
> I also saw the problem with 2.6.36-rc3. My problem is with
> usb_find_interface(&hiddev_driver) not finding anything and
> 9c9e54a8df0be48aa359744f412377cc55c3b7d2 did not change this line.
>
> In its current state I don't understand how hiddev_open() can possibly
> work. I see people reporting suspend issues and stack traces in dmesg
> but nobody reporting the driver being non-functioning, which is what
> I'm doing here.

You are right. I have now applied your patch, thanks a lot for tracking it
down.

--
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/