Re: [PATCH v2 1/3] ARM: pxa168: added support for Teton BGA platform

From: Eric Miao
Date: Tue Sep 14 2010 - 03:08:38 EST


On Mon, Sep 13, 2010 at 11:51 AM, Mark F. Brown <mark.brown314@xxxxxxxxx> wrote:
> Added board defintion, header, and debug UART support.
>
> Signed-off-by: Mark F. Brown <mark.brown314@xxxxxxxxx>
> ---
> ÂMAINTAINERS Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â| Â Â5 +++
> Âarch/arm/mach-mmp/Kconfig         Â|  Â7 ++++
> Âarch/arm/mach-mmp/Makefile         |  Â1 +
> Âarch/arm/mach-mmp/include/mach/teton_bga.h | Â 27 +++++++++++++++
> Âarch/arm/mach-mmp/teton_bga.c       Â|  50 ++++++++++++++++++++++++++++
> Â5 files changed, 90 insertions(+), 0 deletions(-)
> Âcreate mode 100644 arch/arm/mach-mmp/include/mach/teton_bga.h
> Âcreate mode 100644 arch/arm/mach-mmp/teton_bga.c
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 433f353..d7a4481 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -967,6 +967,11 @@ M: Lennert Buytenhek <kernel@xxxxxxxxxxxxxx>
> ÂL: Â Â linux-arm-kernel@xxxxxxxxxxxxxxxxxxx (moderated for non-subscribers)
> ÂS: Â Â Maintained
>
> +ARM/TETON BGA MACHINE SUPPORT
> +M: Â Â Mark F. Brown <mark.brown314@xxxxxxxxx>
> +L: Â Â linux-arm-kernel@xxxxxxxxxxxxxxxxxxx (moderated for non-subscribers)
> +S: Â Â Maintained
> +
> ÂARM/THECUS N2100 MACHINE SUPPORT
> ÂM: Â Â Lennert Buytenhek <kernel@xxxxxxxxxxxxxx>
> ÂL: Â Â linux-arm-kernel@xxxxxxxxxxxxxxxxxxx (moderated for non-subscribers)
> diff --git a/arch/arm/mach-mmp/Kconfig b/arch/arm/mach-mmp/Kconfig
> index 6ab843e..0711d3b 100644
> --- a/arch/arm/mach-mmp/Kconfig
> +++ b/arch/arm/mach-mmp/Kconfig
> @@ -57,6 +57,13 @@ config MACH_MARVELL_JASPER
> Â Â Â Â ÂPXA910-based development board. Since MMP2 is compatible to
> Â Â Â Â ÂARMv6 architecture.
>
> +config MACH_TETON_BGA
> + Â Â Â bool "Marvell's PXA168 Teton BGA Development Board"
> + Â Â Â select CPU_PXA168
> + Â Â Â help
> + Â Â Â Â Say 'Y' here if you want to support the Marvell PXA168-based
> + Â Â Â Â Teton BGA Development Board.
> +
> Âendmenu
>
> Âconfig CPU_PXA168
> diff --git a/arch/arm/mach-mmp/Makefile b/arch/arm/mach-mmp/Makefile
> index 8b66d06..751cdbf 100644
> --- a/arch/arm/mach-mmp/Makefile
> +++ b/arch/arm/mach-mmp/Makefile
> @@ -17,3 +17,4 @@ obj-$(CONFIG_MACH_TAVOREVB) Â += tavorevb.o
> Âobj-$(CONFIG_MACH_TTC_DKB) Â Â += ttc_dkb.o
> Âobj-$(CONFIG_MACH_FLINT) Â Â Â += flint.o
> Âobj-$(CONFIG_MACH_MARVELL_JASPER) += jasper.o
> +obj-$(CONFIG_MACH_TETON_BGA) Â += teton_bga.o
> diff --git a/arch/arm/mach-mmp/include/mach/teton_bga.h b/arch/arm/mach-mmp/include/mach/teton_bga.h
> new file mode 100644
> index 0000000..61a539b
> --- /dev/null
> +++ b/arch/arm/mach-mmp/include/mach/teton_bga.h
> @@ -0,0 +1,27 @@
> +/*
> + * Âlinux/arch/arm/mach-mmp/include/mach/teton_bga.h
> + *
> + * ÂSupport for the Marvell PXA168 Teton BGA Development Platform.
> + *
> + * ÂThis program is free software; you can redistribute it and/or modify
> + * Âit under the terms of the GNU General Public License version 2 as
> + * Âpublishhed by the Free Software Foundation.
> + */
> +#ifndef __ASM_MACH_TETON_BGA_H
> +#define __ASM_MACH_TETON_BGA_H
> +
> +/* GPIOs */
> +#define MMC_PWENA_GPIO Â Â Â Â 27
> +#define USBHPENB_GPIO Â Â Â Â Â55
> +#define RTC_INT_GPIO Â Â Â Â Â 78
> +#define LCD_VBLK_EN_GPIO Â Â Â 79
> +#define LCD_DVDD_EN_GPIO Â Â Â 80
> +#define RST_WIFI_GPIO Â Â Â Â Â81
> +#define CF_PWEN_GPIO Â Â Â Â Â 82
> +#define USB_OC_GPIO Â Â Â Â Â Â83
> +#define PWM_GPIO Â Â Â Â Â Â Â 84
> +#define USBHPENA_GPIO Â Â Â Â Â85
> +#define TS_INT_GPIO Â Â Â Â Â Â86
> +#define CIR_GPIO Â Â Â Â Â Â Â 108
> +
> +#endif /* __ASM_MACH_TETON_BGA_H */
> diff --git a/arch/arm/mach-mmp/teton_bga.c b/arch/arm/mach-mmp/teton_bga.c
> new file mode 100644
> index 0000000..49b746b
> --- /dev/null
> +++ b/arch/arm/mach-mmp/teton_bga.c
> @@ -0,0 +1,50 @@
> +/*
> + * Âlinux/arch/arm/mach-mmp/teton_bga.c
> + *
> + * ÂSupport for the Marvell PXA168 Teton BGA Development Platform.
> + *
> + * ÂAuthor: Mark F. Brown <mark.brown314@xxxxxxxxx>
> + *
> + * ÂThis code is based on aspenite.c
> + *
> + * ÂThis program is free software; you can redistribute it and/or modify
> + * Âit under the terms of the GNU General Public License version 2 as
> + * Âpublishhed by the Free Software Foundation.
> + */
> +
> +#include <linux/init.h>
> +#include <linux/kernel.h>
> +#include <linux/platform_device.h>
> +#include <linux/gpio.h>
> +
> +#include <asm/mach-types.h>
> +#include <asm/mach/arch.h>
> +#include <mach/addr-map.h>
> +#include <mach/mfp-pxa168.h>
> +#include <mach/pxa168.h>
> +#include <mach/teton_bga.h>
> +
> +#include "common.h"
> +
> +static unsigned long teton_bga_pin_config[] __initdata = {
> + Â Â Â /* UART1 */
> + Â Â Â GPIO107_UART1_TXD,
> + Â Â Â GPIO108_UART1_RXD,
> +};
> +
> +static void __init teton_bga_init(void)
> +{
> + Â Â Â mfp_config(ARRAY_AND_SIZE(teton_bga_pin_config));
> +
> + Â Â Â /* on-chip devices */
> + Â Â Â pxa168_add_uart(1);
> +}
> +
> +MACHINE_START(TETON_BGA, "PXA168-based Teton BGA Development Platform")
> +    .phys_io    Â= APB_PHYS_BASE,
> +    .io_pg_offst  Â= (APB_VIRT_BASE >> 18) & 0xfffc,
> +    .map_io     = mmp_map_io,

Added .nr_irqs = IRQ_BOARD_START here, since I've merged Haojian's
patch for enabling SPARSE_IRQ on MMP.

Otherwise all good to me, applied to 'devel'.

> +    .init_irq    = pxa168_init_irq,
> +    .timer     Â= &pxa168_timer,
> +    .init_machine  = teton_bga_init,
> +MACHINE_END
> --
> 1.7.0.4
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/