Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_SPI driver to 2.6.35

[Grant Likely]

On Tue, Sep 14, 2010 at 11:52:30AM +0900, Tomoya MORINAGA wrote:
> ----- Original Message ----- 
> From: "Grant Likely" <grant.likely@xxxxxxxxxxxx>
> To: "Linus Walleij" <linus.ml.walleij@xxxxxxxxx>
> Cc: "Masayuki Ohtake" <masa-korg@xxxxxxxxxxxxxxx>; <meego-dev@xxxxxxxxx>;
> "LKML" <linux-kernel@xxxxxxxxxxxxxxx>; "David Brownell"
> <dbrownell@xxxxxxxxxxxxxxxxxxxxx>; <qi.wang@xxxxxxxxx>;
> <yong.y.wang@xxxxxxxxx>; <andrew.chih.howe.khor@xxxxxxxxx>;
> <arjan@xxxxxxxxxxxxxxx>; <gregkh@xxxxxxx>; "Tomoya MORINAGA"
> <morinaga526@xxxxxxxxxxxxxxx>; "Thomas Gleixner" <tglx@xxxxxxxxxxxxx>;
> "David Woodhouse" <dwmw2@xxxxxxxxxxxxx>
> Sent: Friday, September 10, 2010 1:55 PM
> Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_SPI driver to 2.6.35
> 
> 
> > On Thu, Sep 09, 2010 at 10:58:38PM +0200, Linus Walleij wrote:
> > > 2010/9/3 Masayuki Ohtake <masa-korg@xxxxxxxxxxxxxxx>:
> > >
> > > > Each instance of our SPI device has the same vendor ID and device ID.
> > > > Thus, I think it is impossible to be called probe() for each instance.
> > >
> > > Looking at you latest patch it appears you could :-)
> > > That solves the problem pretty nicely.
> >
> > Actually, it doesn't look like he did.  It looks to me that the
> > ability to support multiple spi bus instances on a single PCI device
> > has simply been removed.  I don't know if that is because it simply
> > isn't needed yet, or if it is because Ohtake-san doesn't quite
> > understand what were suggesting.
> 
> We wanted you to accept multi-instance the SPI patch.
> But seeing maintainer's comments, I felt it is difficult to be accepted.
> Thus, I have deleted whole of multi-instance code.
> 

I've got no problem with the driver supporting multiple instances.  My
comment is simply that it should be implemented in a different way.
But it isn't a big deal.  Multi-instance can be added back into the
driver after the single-instance version is merged.

g.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/