Re: [PATCH v2] AT91: Add flexibity board support

From: Ryan Mallon
Date: Mon Sep 13 2010 - 16:53:15 EST


On 09/13/2010 10:18 PM, Maxim Osipov wrote:
> Hello,
>
> This patch adds support for AT91 Flexibity board.

Couple more comments below,

> From ccb19f0d6dbda5356e64c1ce5d0fe1396c548f1a Mon Sep 17 00:00:00 2001
> From: Maxim Osipov <maxim.osipov@xxxxxxxxx>
> Date: Sun, 12 Sep 2010 16:23:48 +0400
> Subject: [PATCH v2] AT91: Add flexibity board support
>
> Signed-off-by: Maxim Osipov <maxim.osipov@xxxxxxxxx>
> ---

> +#include <linux/init.h>
> +#include <linux/platform_device.h>
> +#include <linux/spi/spi.h>
> +#include <linux/input.h>
> +
> +#include <asm/mach-types.h>
> +
> +#include <asm/mach/arch.h>
> +#include <asm/mach/map.h>
> +#include <asm/mach/irq.h>
> +
> +#include <mach/hardware.h>
> +#include <mach/board.h>
> +#include <mach/gpio.h>

Use linux/gpio.h

> +
> +#include "generic.h"
> +
> +

Single blank line here, and between functions.

> +
> +static void __init flexibity_board_init(void)
> +{
> + /* Serial */
> + at91_add_device_serial();
> + /* USB Host */
> + at91_add_device_usbh(&flexibity_usbh_data);
> + /* USB Device */
> + at91_add_device_udc(&flexibity_udc_data);
> + /* SPI */
> + at91_add_device_spi(flexibity_spi_devices,
> + ARRAY_SIZE(flexibity_spi_devices));
> + /* MMC */
> + at91_add_device_mmc(0, &flexibity_mmc_data);
> + /* LEDs */
> + at91_gpio_leds(flexibity_leds, ARRAY_SIZE(flexibity_leds));

Can we drop all the comments inside this function please. They don't add
any information and they make it harder to read the actual code.

~Ryan

--
Bluewater Systems Ltd - ARM Technology Solution Centre

Ryan Mallon 5 Amuri Park, 404 Barbadoes St
ryan@xxxxxxxxxxxxxxxx PO Box 13 889, Christchurch 8013
http://www.bluewatersys.com New Zealand
Phone: +64 3 3779127 Freecall: Australia 1800 148 751
Fax: +64 3 3779135 USA 1800 261 2934
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/