Re: [PATCH 0/2] lio-target: Add support for libcrypto crc32c andcrc32-intel offload

[Mike Christie]

On 09/13/2010 02:50 PM, Nicholas A. Bellinger wrote:
> > IE the in-kernel crc32c routines apparently weren't able to
> > calculate the checksum in an endianness-independent manner.
> > So a CRC calculated on a BE machine would fail to be validated by a
> > LE machine and vice versa.
> >
> > Has this been fixed / verified?
>
> > From taking a look at crypto/crc32c.c it still appears AFAICT to not be
> big endian safe.  I was planning to test this patch on some powerpc/ppc
> hardware with v2.6.36-rc4 in the next days, but it looks like
> lio-core-2.6.git will need a seperate crypto/crc32c.c patch to function
> properly on big endian arches.

There was this bug that was fixed a couple years ago:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=ef19454bd437b2ba14c9cda1de85debd9f383484
since then I think we have not had problems.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/