RE: [PATCH 14/25] drivers/net/vnxnet3: Use static const char arrays

From: Shreyas Bhatewara
Date: Mon Sep 13 2010 - 16:07:17 EST


Thanks Joe.

Acked-by: Shreyas Bhatewara <sbhatewara@xxxxxxxxxx>

> -----Original Message-----
> From: Joe Perches [mailto:joe@xxxxxxxxxxx]
> Sent: Monday, September 13, 2010 12:48 PM
> To: linux-kernel@xxxxxxxxxxxxxxx
> Cc: Shreyas Bhatewara; VMware, Inc.; netdev@xxxxxxxxxxxxxxx
> Subject: [PATCH 14/25] drivers/net/vnxnet3: Use static const char
> arrays
>
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> ---
> drivers/net/vmxnet3/vmxnet3_drv.c | 2 +-
> drivers/net/vmxnet3/vmxnet3_int.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c
> b/drivers/net/vmxnet3/vmxnet3_drv.c
> index 198ce92..dfc0014 100644
> --- a/drivers/net/vmxnet3/vmxnet3_drv.c
> +++ b/drivers/net/vmxnet3/vmxnet3_drv.c
> @@ -28,7 +28,7 @@
>
> #include "vmxnet3_int.h"
>
> -char vmxnet3_driver_name[] = "vmxnet3";
> +const char vmxnet3_driver_name[] = "vmxnet3";
> #define VMXNET3_DRIVER_DESC "VMware vmxnet3 virtual NIC driver"
>
> /*
> diff --git a/drivers/net/vmxnet3/vmxnet3_int.h
> b/drivers/net/vmxnet3/vmxnet3_int.h
> index 2121c73..201fcf7 100644
> --- a/drivers/net/vmxnet3/vmxnet3_int.h
> +++ b/drivers/net/vmxnet3/vmxnet3_int.h
> @@ -384,5 +384,5 @@ vmxnet3_create_queues(struct vmxnet3_adapter
> *adapter,
> extern void vmxnet3_set_ethtool_ops(struct net_device *netdev);
> extern struct net_device_stats *vmxnet3_get_stats(struct net_device
> *netdev);
>
> -extern char vmxnet3_driver_name[];
> +extern const char vmxnet3_driver_name[];
> #endif
> --
> 1.7.3.rc1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/