Re: [PATCH] mmc: Add architecture dependency for Marvell SoCcontroller

From: Mark Brown
Date: Mon Sep 13 2010 - 08:02:59 EST


On Mon, Sep 13, 2010 at 12:48:38PM +0200, Arnd Bergmann wrote:

> I think we normally try to do the the other way round: in order to increase
> build coverage, try to enable all drivers on as many platforms as possible,
> just don't have them in the defconfig.

This is not the general pattern for on-CPU devices on the embedded SoCs,
for those we normally only offer the config option when building for a
system which could physically have the device. Looking at the existing
MMC host drivers you'll see this pattern is already heavily used there -
all the existing embedded controllers have similar dependencies.

> Do you get build errors on other platforms? If yes, there is probably
> a bug in the driver that should be fixed instead.

No, I didn't even try to build it - I saw that I was being offered a
device for a Marvell CPU when building for a non-Marvell CPU.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/