Re: [PATCH 4/5] writeback: Adding/sys/devices/system/node/<node>/vmstat

From: Wu Fengguang
Date: Sun Sep 12 2010 - 23:03:11 EST


On Mon, Sep 13, 2010 at 04:30:39AM +0800, Michael Rubin wrote:
> For NUMA node systems it is important to have visibility in memory
> characteristics. Two of the /proc/vmstat values "nr_cleaned" and

s/nr_cleaned/nr_written/

> "nr_dirtied" are added here.
>
> # cat /sys/devices/system/node/node20/vmstat
> nr_cleaned 0

ditto

> nr_dirtied 0
>
> Signed-off-by: Michael Rubin <mrubin@xxxxxxxxxx>

Reviewed-by: Wu Fengguang <fengguang.wu@xxxxxxxxx>

> +static ssize_t node_read_vmstat(struct sys_device *dev,
> + struct sysdev_attribute *attr, char *buf)
> +{
> + int nid = dev->id;
> + return sprintf(buf,
> + "nr_written %lu\n"
> + "nr_dirtied %lu\n",
> + node_page_state(nid, NR_WRITTEN),
> + node_page_state(nid, NR_FILE_DIRTIED));
> +}

Do you have plan to port more vmstat_text[] items? :)

Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/