Re: [PATCH -next] optprobes: fix kconfig depends/selects

From: Felipe Contreras
Date: Sun Sep 12 2010 - 14:41:16 EST


On Sun, Sep 12, 2010 at 9:34 PM, Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote:
> On 09/12/10 03:49, Felipe Contreras wrote:
>> On Thu, Aug 12, 2010 at 10:26 PM, Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote:
>>> From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
>>>
>>> KALLSYMS and KALLSYMS_ALL depend on DEBUG_KERNEL, so add that dependency.
>>> KALLSYMS_ALL depends on KALLSYMS, so select both of them, not just KALLSYMS_ALL.
>>>
>>> warning: (OPTPROBES && KPROBES && HAVE_OPTPROBES && !PREEMPT || MTD_UBI_DEBUG && MTD && SYSFS && MTD_UBI || UBIFS_FS_DEBUG && MISC_FILESYSTEMS && UBIFS_FS || LOCKDEP && DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT || LATENCYTOP && HAVE_LATENCYTOP_SUPPORT) selects KALLSYMS_ALL which has unmet direct dependencies (DEBUG_KERNEL && KALLSYMS)
>>>
>>> Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
>>> Cc: Â Â Ananth N Mavinakayanahalli <ananth@xxxxxxxxxx>
>>> Cc: Â Â Anil S Keshavamurthy <anil.s.keshavamurthy@xxxxxxxxx>
>>> Cc: Â Â "David S. Miller" <davem@xxxxxxxxxxxxx>
>>> Cc: Â Â Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx>
>>> ---
>>> Âarch/Kconfig | Â Â2 ++
>>> Â1 file changed, 2 insertions(+)
>>>
>>> --- linux-next-20100810.orig/arch/Kconfig
>>> +++ linux-next-20100810/arch/Kconfig
>>> @@ -45,6 +45,8 @@ config OPTPROBES
>>> Â Â Â Âdef_bool y
>>> Â Â Â Âdepends on KPROBES && HAVE_OPTPROBES
>>> Â Â Â Âdepends on !PREEMPT
>>> + Â Â Â depends on DEBUG_KERNEL
>>> + Â Â Â select KALLSYMS
>>> Â Â Â Âselect KALLSYMS_ALL
>>>
>>> Âconfig HAVE_EFFICIENT_UNALIGNED_ACCESS
>>> --
>>
>> This causes another problem:
>>
>> arch/Kconfig:33:error: recursive dependency detected!
>> arch/Kconfig:33: Â Â Âsymbol KPROBES depends on KALLSYMS
>> init/Kconfig:825: Â Â symbol KALLSYMS is selected by OPTPROBES
>> arch/Kconfig:44: Â Â Âsymbol OPTPROBES depends on KPROBES
>>
>> The 'select KALLSYMS' is redundant.
>>
>> Otherwise: Signed-off-by: Felipe Contreras <felipe.contreras@xxxxxxxxx>
>
> Thanks for checking. ÂI saw this problem just a day or two ago myself.
>
> Dropping the select does not eliminate the kconfig warning.
> I'll try something else.

Huh? The original warning is gone by just adding 'depends on DEBUG_KERNEL'.

--
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/