Re: [PATCH] fs/btrfs/ordered-data.c: fixed compiler warnings forusing uninitialized variable

[Felipe Contreras]

On Fri, Sep 10, 2010 at 5:42 PM, Frank Morales II <altf2o@xxxxxxxxx> wrote:
> >From 1c304defc543738f82ccb18fe10b558dd2098d74 Mon Sep 17 00:00:00 2001
> From: Frank Morales II <altf2o@xxxxxxxxx>
> Date: Fri, 10 Sep 2010 07:34:23 -0700
> Subject: [PATCH] fs/btrfs/ordered-data.c: fixed compiler warnings for using uninitialized variable
>
> In the function tree_search, the variable prev was used without first
> being initialized, causing compiler warning messages. Initializing
> prev to NULL resolved the issue.
>
> Kernal patched against: 2.6.36-rc3 (df423dc7)

Signed-of-by: Felipe Contreras <felipe.contreras@xxxxxxxxx>

I came up with exactly this patch, but this is my commit message:

    Btrfs: fix compilation warning

    fs/btrfs/ordered-data.c: In function âtree_searchâ:
    fs/btrfs/ordered-data.c:144: warning: âprevâ may be used
uninitialized in this function
    fs/btrfs/ordered-data.c: In function âbtrfs_lookup_first_ordered_extentâ:
    fs/btrfs/ordered-data.c:144: warning: âprevâ may be used
uninitialized in this function
    fs/btrfs/ordered-data.c:144: note: âprevâ was declared here
    fs/btrfs/ordered-data.c: In function âbtrfs_lookup_ordered_extentâ:
    fs/btrfs/ordered-data.c:144: warning: âprevâ may be used
uninitialized in this function
    fs/btrfs/ordered-data.c:144: note: âprevâ was declared here
    fs/btrfs/ordered-data.c: In function âbtrfs_lookup_ordered_rangeâ:
    fs/btrfs/ordered-data.c:144: warning: âprevâ may be used
uninitialized in this function
    fs/btrfs/ordered-data.c:144: note: âprevâ was declared here
    fs/btrfs/ordered-data.c: In function âbtrfs_dec_test_ordered_pendingâ:
    fs/btrfs/ordered-data.c:144: warning: âprevâ may be used
uninitialized in this function
    fs/btrfs/ordered-data.c:144: note: âprevâ was declared here

    __tree_search() might not set &prev.

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/