Re: [PATCH 2.6.35.4] irq: irq and pci_ids patch for Intel PatsburgDeviceIDs

From: Jean Delvare
Date: Sat Sep 11 2010 - 04:57:39 EST


Hi Seth,

On Fri, 10 Sep 2010 16:36:39 -0700, Seth Heasley wrote:
> This patch adds the LPC Controller DeviceIDs for the Intel Patsburg PCH.
>
> Signed-off-by: Seth Heasley <seth.heasley@xxxxxxxxx>
>
> --- linux-2.6.35.4/include/linux/pci_ids.h.orig 2010-08-26 16:47:12.000000000 -0700
> +++ linux-2.6.35.4/include/linux/pci_ids.h 2010-09-10 16:34:06.000000000 -0700
> @@ -2423,6 +2423,7 @@
> #define PCI_DEVICE_ID_INTEL_CPT_SMBUS 0x1c22
> #define PCI_DEVICE_ID_INTEL_CPT_LPC_MIN 0x1c41
> #define PCI_DEVICE_ID_INTEL_CPT_LPC_MAX 0x1c5f
> +#define PCI_DEVICE_ID_INTEL_PBG_LPC 0x1d40
> #define PCI_DEVICE_ID_INTEL_82801AA_0 0x2410
> #define PCI_DEVICE_ID_INTEL_82801AA_1 0x2411
> #define PCI_DEVICE_ID_INTEL_82801AA_3 0x2413
> --- linux-2.6.35.4/arch/x86/pci/irq.c.orig 2010-08-26 16:47:12.000000000 -0700
> +++ linux-2.6.35.4//arch/x86/pci/irq.c 2010-09-10 16:30:39.000000000 -0700
> @@ -589,6 +589,7 @@
> case PCI_DEVICE_ID_INTEL_ICH10_1:
> case PCI_DEVICE_ID_INTEL_ICH10_2:
> case PCI_DEVICE_ID_INTEL_ICH10_3:
> + case PCI_DEVICE_ID_INTEL_PBG_LPC:
> r->name = "PIIX/ICH";
> r->get = pirq_piix_get;
> r->set = pirq_piix_set;

Could Intel please stop using abbreviations for their chip names? If
the chip is named Patsburg then please use PATSBURG in the symbol names
too. MRST, PGB, etc. make me sick.

Thanks,
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/