Re: [PATCH 23/41] dm: implement REQ_FLUSH/FUA support for bio-baseddm

[Mike Snitzer]

On Fri, Sep 10 2010 at  2:25pm -0400,
Mikulas Patocka <mpatocka@xxxxxxxxxx> wrote:

> I quite disagree with the patch. It changes too many things.
> 
> What I said and what I want to see:
> 
> Take dm code as is. Treat FLUSH requests as empty barriers.
> 
> 
> So I want to see a patch that only changes:
> 
> bio_empty_barrier(bio)  ->  bio->bi_rw & REQ_FLUSH
> WRITE_BARRIER -> WRITE_FLUSH
> etc.
> 
> so that the code compiles and works.
> 
> DON'T CHANGE ANYTHING ELSE.
> 
> Requirements of flushes are subset of requirements of barriers, so if you 
> send flush and it is treated as a barrier inside DM, there's no problem. 
> DM code that I wrote only sends out zero-data barriers and already treats 
> them as flushes (it doesn't rely on ordering), so there's no problem with 
> sent requests too.
> 
> Once fluges get into kernel, I'll clean it up to allow parallel flushes 
> and requests, etc. But not before. I don't want to work on an interface 
> that is under development and may be changed.

Mikulas,

I agree that it is unfortunate that we're having to explore this level
of change to DM's flush support.  Especially given how recently your
barrier code was added.

But the work has already been done.  Rather than putting up artificial
barriers (no pun intended) it'd be great if you took the time to just
review the changes.

The patch header enumerates and describes the various changes quite
clearly.

And in fact, this first patch basically is as minimal as it gets
relative to bio-based DM's conversion to FLUSH+FUA.

Please direct your energy and talent in a positive way rather than
starting a potential flame.

Thanks,
Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/