Re: [PATCH percpu#for-next] percpu: clear memory allocated with thekm allocator

From: Randy Dunlap
Date: Fri Sep 10 2010 - 12:33:22 EST


On Fri, 10 Sep 2010 10:55:18 +0200 Peter Zijlstra wrote:

> On Fri, 2010-09-10 at 10:52 +0200, Tejun Heo wrote:
> > Percpu allocator should clear memory before returning it but the km
> > allocator forgot to do it. Fix it.
> >
> > Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> > Spotted-by: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
>
> (fwiw, -tip uses Reported-by)

fyi, Documentation/SubmittingPatches does also.


> Acked-by: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
>
> > ---
> > mm/percpu-km.c | 6 +++++-
> > 1 files changed, 5 insertions(+), 1 deletions(-)
> >
> > diff --git a/mm/percpu-km.c b/mm/percpu-km.c
> > index 7037bc7..89633fe 100644
> > --- a/mm/percpu-km.c
> > +++ b/mm/percpu-km.c
> > @@ -35,7 +35,11 @@
> >
> > static int pcpu_populate_chunk(struct pcpu_chunk *chunk, int off, int size)
> > {
> > - /* noop */
> > + unsigned int cpu;
> > +
> > + for_each_possible_cpu(cpu)
> > + memset((void *)pcpu_chunk_addr(chunk, cpu, 0) + off, 0, size);
> > +
> > return 0;
> > }


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/