Re: [PATCH] perf_events: fix BTS interrupt handling to avoid beingdazed by NMI (v2)

From: Don Zickus
Date: Fri Sep 10 2010 - 09:26:13 EST


On Fri, Sep 10, 2010 at 01:28:01PM +0200, Stephane Eranian wrote:
> Fix a bug introduced with commit de725de and the change in the meaning of the
> return value of intel_pmu_handle_irq(). With the current code, when you are
> using the BTS, you get 'dazed by NMI' each time the BTS buffer fills up.
>
> BTS does interrupt on the PMU vector, thus NMI. You need to take this
> into account in the return value of the function.
>
> This version fixes initial patch which was missing changes to
> perf_event_intel_ds.c.

Great work!

So does this mean my other patch that ack'd the intel pmu earlier than
before is unnecessary now? Or was this patch solving a different problem?

Cheers,
Don
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/