Re: [PATCH] AT91: at91sam9261ek board: remove warnings related touse of SPI or SD/MMC

From: Jean-Christophe PLAGNIOL-VILLARD
Date: Fri Sep 10 2010 - 07:07:31 EST


> > * ADS7846 Touchscreen
> >@@ -357,6 +350,21 @@ static struct spi_board_info ek_spi_devices[] = {
> > #endif
> > };
> >
> >+#else /* CONFIG_SPI_ATMEL_* */
> >+
> >+/*
> >+ * MCI (SD/MMC)
> >+ * spi0 and mmc/sd share the same PIO pins: cannot be used at the same time
> >+ */
> >+static struct at91_mmc_data __initdata ek_mmc_data = {
> >+ .wire4 = 1,
> >+// .det_pin = ... not connected
> >+// .wp_pin = ... not connected
> >+// .vcc_pin = ... not connected
>
> The coding style document forbids C99 style // comments. Could
> replace with normal comment or #if 0...
no dead code please

Best Regards,
J.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/