Re: [PATCH 05/10] vmscan: Synchrounous lumpy reclaim use lock_page() instead trylock_page()

From: KOSAKI Motohiro
Date: Fri Sep 10 2010 - 06:33:43 EST


> Afaik, detailed rule is,
>
> o kswapd can call lock_page() because they never take page lock outside vmscan

s/lock_page()/lock_page_nosync()/



> o if try_lock() is successed, we can call lock_page_nosync() against its page after unlock.
> because the task have gurantee of no lock taken.
> o otherwise, direct reclaimer can't call lock_page(). the task may have a lock already.
>
> I think.
>
>
> > I did not
> > think of an obvious example of when this would happen. Similarly,
> > deadlock situations with mmap_sem shouldn't happen unless multiple page
> > locks are being taken.
> >
> > (prepares to feel foolish)
> >
> > What did I miss?
>
>
>
>
>



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/