Re: [-next Sept 9] S309 Build break (mm/percpu.c)

From: Sachin Sant
Date: Fri Sep 10 2010 - 02:09:43 EST


Tejun Heo wrote:
Commit bbddff05 (percpu: use percpu allocator on UP too) incorrectly
excluded pcpu_build_alloc_info() on SMP configurations which use
generic setup_per_cpu_area() like s390. The config ifdefs are
becoming confusing. Fix and clean it up by,

* Move pcpu_build_alloc_info() right on top of its two users -
pcpu_{embed|page}_first_chunk() which are already in CONFIG_SMP
block.

* Define BUILD_{EMBED|PAGE}_FIRST_CHUNK which indicate whether each
first chunk function needs to be included and use them to control
inclusion of the three functions to reduce confusion.

Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
Reported-by: Sachin Sant <sachinp@xxxxxxxxxx>
---
Can you please test this patch?
Tested the patch against yesterday's next release(20100909). Works fine.

Thanks Tejun.

Regards
-Sachin

--

---------------------------------
Sachin Sant
IBM Linux Technology Center
India Systems and Technology Labs
Bangalore, India
---------------------------------

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/