Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_SPI driver to 2.6.35

[Grant Likely]

On Thu, Sep 09, 2010 at 10:58:38PM +0200, Linus Walleij wrote:
> 2010/9/3 Masayuki Ohtake <masa-korg@xxxxxxxxxxxxxxx>:
> 
> > Each instance of our SPI device has the same vendor ID and device ID.
> > Thus, I think it is impossible to be called probe() for each instance.
> 
> Looking at you latest patch it appears you could :-)
> That solves the problem pretty nicely.

Actually, it doesn't look like he did.  It looks to me that the
ability to support multiple spi bus instances on a single PCI device
has simply been removed.  I don't know if that is because it simply
isn't needed yet, or if it is because Ohtake-san doesn't quite
understand what were suggesting.

Regardless it doesn't matter.  When or if the driver does need to be
modified to support multiple instances, it is a relatively straight
forward matter to refactor the current code into a platform_driver,
and create a new pci_driver that simply registers the matching
platform_device for each spi bus instance supported by the device.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/