[PATCH] ipmi: fix acpi probe print

From: Corey Minyard
Date: Thu Sep 09 2010 - 22:44:13 EST


From: Yinghai Lu <yinghai@xxxxxxxxxx>

After
|commit d9e1b6c45059ccfff647a120769ae86da78dfdc4
|
| ipmi: fix ACPI detection with regspacing

got
[ 11.026326] ipmi_si: probing via ACPI
[ 11.030019] ipmi_si 00:09: (null) regsize 1 spacing 1 irq 0
[ 11.035594] ipmi_si: Adding ACPI-specified kcs state machine

on old system with only one range for ipmi kcs range.

Try to fix it by adding another res pointer.

Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx>
Signed-off-by: Corey Minyard <cminyard@xxxxxxxxxx>

---
drivers/char/ipmi/ipmi_si_intf.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

Index: linux-2.6.35/drivers/char/ipmi/ipmi_si_intf.c
===================================================================
--- linux-2.6.35.orig/drivers/char/ipmi/ipmi_si_intf.c 2010-09-09 21:26:35.980978855 -0500
+++ linux-2.6.35/drivers/char/ipmi/ipmi_si_intf.c 2010-09-09 21:26:50.542230669 -0500
@@ -2126,7 +2126,7 @@
{
struct acpi_device *acpi_dev;
struct smi_info *info;
- struct resource *res;
+ struct resource *res, *res_second;
acpi_handle handle;
acpi_status status;
unsigned long long tmp;
@@ -2182,13 +2182,13 @@
info->io.addr_data = res->start;

info->io.regspacing = DEFAULT_REGSPACING;
- res = pnp_get_resource(dev,
+ res_second = pnp_get_resource(dev,
(info->io.addr_type == IPMI_IO_ADDR_SPACE) ?
IORESOURCE_IO : IORESOURCE_MEM,
1);
- if (res) {
- if (res->start > info->io.addr_data)
- info->io.regspacing = res->start - info->io.addr_data;
+ if (res_second) {
+ if (res_second->start > info->io.addr_data)
+ info->io.regspacing = res_second->start - info->io.addr_data;
}
info->io.regsize = DEFAULT_REGSPACING;
info->io.regshift = 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/