Re: [PATCH] USB: isp1362-hcd: Removes CONFIG_USB_OTG dependent code,fix build breakage

From: Mike Frysinger
Date: Thu Sep 09 2010 - 19:05:32 EST


On Thu, Sep 9, 2010 at 17:31, Javier Martinez Canillas wrote:
> In today linux-next I got a compile error on usb/host/isp1362-hcd:
>
> drivers/usb/host/isp1362-hcd.c: In function âisp1362_hub_controlâ:
> drivers/usb/host/isp1362-hcd.c:1680: error: âohciâ undeclared (first use in this function)
>
> The problem is when the CONFIG_USB_OTG option is enabled.
>
> ohci variable is never declared and there isn't any CONFIG_USB_OTG dependent code
> besides the portion defined in isp1362_hub_control.
>
> So I think that maybe USB OTG support is not needed/supported.
>
> This patch removes the CONFIG_USB_OTG dependent block so the driver can compile cleanly.

i dont believe we've ever used OTG (or if our test board is even wired
up to support it), so this is fine by me. let the guy who actually
uses OTG worry about it. presumably no one has yet if it doesnt even
compile ...
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/