Re: [PATCH] exec: don't turn PF_KTHREAD off when command not found

From: Oleg Nesterov
Date: Thu Sep 09 2010 - 16:42:36 EST


On 09/09, KOSAKI Motohiro wrote:
>
> I guess this is only theorical issue because now any kthread don't
> call do_execve() directly.

Yes, I think that kthread should always exit if exec fails.
Otherwise we can "trust" the thread, just suppose that exec fails
after exec_mmap() succeeds.

But,

> but anyway fixing would be better.

Agreed. It looks better if we clear PF_KTHREAD after the point-of-no-return,
and the patch saves one ->flags modification.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/