Re: [PATCH] Backlight: Add backlight type

[Mike Frysinger]

On Wed, Sep 8, 2010 at 12:32, Matthew Garrett <mjg@xxxxxxxxxx> wrote:
> There may be multiple ways of controlling the backlight on a given machine.
> Allow drivers to expose the type of interface they are providing, making
> it possible for userspace to make appropriate policy decisions.

maybe i missed something, but i dont see the core validating the .type
value at registration time.  since the value is then used later as an
index into an array, shouldnt it verify that it is valid ?

do you want to force everyone to declare they're "raw" ?  or just go
with the memset default to have people start with "raw" ?  otherwise
it might make sense to have the first enum be BACKLIGHT_UNKNOWN and
have the core warn when it hits that.

> --- a/drivers/video/backlight/backlight.c
> +++ b/drivers/video/backlight/backlight.c
>
> +static const char *backlight_types[] = {
> + Â Â Â [BACKLIGHT_RAW] = "raw",
> + Â Â Â [BACKLIGHT_PLATFORM] = "platform",
> + Â Â Â [BACKLIGHT_FIRMWARE] = "firmware",
> +};

const char * const backlight_types[] ?
-mke
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/