Re: [patch] pm_qos_params: cleanup: terminate a string

From: Rafael J. Wysocki
Date: Wed Sep 08 2010 - 18:15:28 EST


On Tuesday, September 07, 2010, mark gross wrote:
> On Mon, Sep 06, 2010 at 11:22:27PM -0700, mark gross wrote:
> > On Fri, Sep 03, 2010 at 02:41:06PM +0200, Dan Carpenter wrote:
...
>
> updated patch
>
> Signed-off-by: mark gross <markgross@xxxxxxxxxxx>
>
> --mgross
>
> Subject: [PATCH] correct some pr_debug misuse and add a stronger parrameter check to
> pm_qos_write for the ascii hex value case. Thanks to Dan Carpenter for
> pointing out the problem!
>
> ---
> kernel/pm_qos_params.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/pm_qos_params.c b/kernel/pm_qos_params.c
> index f42d3f7..aae58d2 100644
> --- a/kernel/pm_qos_params.c
> +++ b/kernel/pm_qos_params.c
> @@ -155,7 +155,7 @@ static void update_target(int pm_qos_class)
> call_notifier = 1;
> atomic_set(&pm_qos_array[pm_qos_class]->target_value,
> extreme_value);
> - pr_debug(KERN_ERR "new target for qos %d is %d\n", pm_qos_class,
> + pr_debug("new target for qos %d is %d\n", pm_qos_class,
> atomic_read(&pm_qos_array[pm_qos_class]->target_value));
> }
> spin_unlock_irqrestore(&pm_qos_lock, flags);

The above doesn't apply to the Linus' tree any more. Care to fix?

Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/