Re: [PATCHv6 3/3] mmc_test: collect data and show it via sysfs bydemand

[Andrew Morton]

On Wed, 8 Sep 2010 12:08:58 +0300
Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:

> On Wed, Sep 8, 2010 at 1:27 AM, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> >> Here is a patch which brings possibility to get test results via sysfs. It
> >> helps to do tests non-interactively.
> >>
> >> We have the file created under sysfs already and we could use it to out test
> >> results.
> >
> > So what we end up with is extremely thin. __Something about adding
> > something to sysfs.
> Yeah, agree with you. How to proceed with commit messages?
> Should I make newer version of this certain patch with updated commit message?
> 

I used the words which Chris sent:


: Make it possibile to get test results via sysfs.  It helps to do tests
: non-interactively.
: 
: We have the file created under sysfs already and we could use it to out test
: results.
: 
: Prior to this patch, the "test" file under each card's sysfs node was
: write-only, and results were obtained by looking at dmesg.  This patch
: improves programmatic access to the test results, making them available by
: reading back from the same "test" file:
: 
: [root@host mmc0:e624]# echo 6 > test
: [root@host mmc0:e624]# cat test
: Test 6: 2
: 
: [cjb@xxxxxxxxxx: changelog improvements]
: Signed-off-by: Andy Shevchenko <ext-andriy.shevchenko@xxxxxxxxx>
: Cc: Chris Ball <cjb@xxxxxxxxxx>
: Cc: <linux-mmc@xxxxxxxxxxxxxxx>

which is good enough.  You can send me replacement changelog text any
old time - it's not problem.  I'm forever editing changelogs, mainly
adding acked-by's etc.  

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/