Re: [GIT pull] Preparatory patch for semaphore cleanup

[Ingo Molnar]

* Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> On Wed, 2010-09-08 at 07:54 -0700, Linus Torvalds wrote:
> > On Wed, Sep 8, 2010 at 6:11 AM, Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
> > >
> > > This patch just provides the DEFINE_SEMAPHORE macro which is required
> > > for the various subsystem cleanups I sent out, so we can finally get
> > > rid of init_MUTEX[_LOCKED] in 2.6.37.
> > 
> > Why is it called DEFINE_SEMAPHORE(), when two lines later the we have
> > DECLARE_MUTEX()?
> > 
> > IOW, the whole DEFINE vs DECLARE thing seems confused. I'm not saying
> > one is better than the other (maybe "define" is), but the mixing of
> > names is worse than either, I feel..
> 
> The rest of the series, that Thomas didn't include in this pull, removes
> all the DECLARE_MUTEX() users. So its temporary awkward-ness.

and DEFINE_MUTEX() is needed upstream so that we can spread those 
patches into a dozen maintainer trees. Once those flow upstream 
DECLARE_MUTEX() will be removed.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/