Re: [PATCH] identify firmware version

From: Rafi Rubin
Date: Wed Sep 08 2010 - 11:43:25 EST


On 09/08/10 05:47, Jiri Kosina wrote:
> On Tue, 7 Sep 2010, Jiri Slaby wrote:
>
>>>>>> +
>>>>>> + ret = ntrig_version_string(&data[2], buf);
>>>>>> +
>>>>>> + dev_info(&hdev->dev,
>>>>>> + "Firmware version: %s (%02x%02x %02x%02x)\n",
>>>>>> + buf, data[2], data[3], data[4], data[5]);
>>>>>> +
>>>>>> + kfree(buff);
>>>>
>>>> In any case, this doesn't compile...
>>>>
>>>>>> + }
>>>
>>> Jiri, I moved the code to a separate function as Dmitry suggested, and compiled a kernel from a clean tree using
>>> gcc-3.4 (I think).
>>
>> This version is OK. In the previous one, there was
>> char *buf;
>> ...
>> kfree(buff);
>
> Dmitry, Jiri, thanks a lot for taking care reviewing the patch while I
> have been lagging behind.
>
> Now applied, thanks Rafi.

Thanks Jiri, and thanks for all the feedback.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/