Re: [PATCH] hwmon: Add support for max6695 and max6696 to lm90 driver

[Jean Delvare]

On Wed, 8 Sep 2010 06:56:54 -0700, Guenter Roeck wrote:
> Too bad - registers 0x16 and 0x17 exist on both 6658 and 6659. So the only way to detect 6659 
> would be the address (0x4d or 0x4e), and we would mis-detect it on 0x4c. Is that worth it ?

I'd say adding support for the MAX6659 is worth it. Just don't add
detection. That is, all of MAX6657, 6658 and 6658 should be detected as
max6657, which has the minimum set of features. But if someone declares
a "max6659" device either as part of the platform data or from
user-space, then the driver should expose all the chip features.

Deal?

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/