Re: [PATCH v3] i2c: QUP based bus driver for Qualcomm MSM chipsets

From: Trilok Soni
Date: Wed Sep 08 2010 - 09:23:55 EST


On 9/8/2010 6:29 AM, Kenneth Heitke wrote:
> This bus driver supports the QUP i2c hardware controller in the Qualcomm
> MSM SOCs. The Qualcomm Universal Peripheral Engine (QUP) is a general
> purpose data path engine with input/output FIFOs and an embedded i2c
> mini-core. The driver supports FIFO mode (for low bandwidth applications)
> and block mode (interrupt generated for each block-size data transfer).
> The driver currently does not support DMA transfers.
>
> Signed-off-by: Kenneth Heitke <kheitke@xxxxxxxxxxxxxx>
> ---
> v3: uses DIV_ROUND_UP() as recommended by linus.walleij@xxxxxxxxxxxxxx
> v2: incorporated feedback from the following people:
> ben-linux@xxxxxxxxx
> srinidhi.kasagar@xxxxxxxxxxxxxx
> tsoni@xxxxxxxxxxxxxx

Looks good to me.

Acked-by: Trilok Soni <tsoni@xxxxxxxxxxxxxx>

---Trilok Soni

--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/