[sparc build bug] Re: [tip:perf/core] irq: Add tracepoint tosoftirq_raise

From: Ingo Molnar
Date: Wed Sep 08 2010 - 07:26:11 EST



* tip-bot for Lai Jiangshan <laijs@xxxxxxxxxxxxxx> wrote:

> Commit-ID: 2bf2160d8805de64308e2e7c3cd97813cb58ed2f
> Gitweb: http://git.kernel.org/tip/2bf2160d8805de64308e2e7c3cd97813cb58ed2f
> Author: Lai Jiangshan <laijs@xxxxxxxxxxxxxx>
> AuthorDate: Mon, 23 Aug 2010 18:42:48 +0900
> Committer: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> CommitDate: Tue, 7 Sep 2010 17:49:34 +0200
>
> irq: Add tracepoint to softirq_raise
>
> Add a tracepoint for tracing when softirq action is raised.
>
> This and the existing tracepoints complete softirq's tracepoints:
> softirq_raise, softirq_entry and softirq_exit.
>
> And when this tracepoint is used in combination with
> the softirq_entry tracepoint we can determine
> the softirq raise latency.
>
> Signed-off-by: Lai Jiangshan <laijs@xxxxxxxxxxxxxx>
> Acked-by: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx>
> Acked-by: Neil Horman <nhorman@xxxxxxxxxxxxx>
> Cc: David Miller <davem@xxxxxxxxxxxxx>
> Cc: Kaneshige Kenji <kaneshige.kenji@xxxxxxxxxxxxxx>
> Cc: Izumo Taku <izumi.taku@xxxxxxxxxxxxxx>
> Cc: Kosaki Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>
> Cc: Lai Jiangshan <laijs@xxxxxxxxxxxxxx>
> Cc: Scott Mcmillan <scott.a.mcmillan@xxxxxxxxx>
> Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
> Cc: Eric Dumazet <eric.dumazet@xxxxxxxxx>
> LKML-Reference: <4C724298.4050509@xxxxxxxxxxxxxx>
> [ factorize softirq events with DECLARE_EVENT_CLASS ]
> Signed-off-by: Koki Sanagi <sanagi.koki@xxxxxxxxxxxxxx>
> Signed-off-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> ---
> include/linux/interrupt.h | 8 +++++++-
> include/trace/events/irq.h | 26 ++++++++++++++++++++++++--
> 2 files changed, 31 insertions(+), 3 deletions(-)

FYI, this commit broke the Sparc build:

In file included from /home/mingo/tip/arch/sparc/include/asm/irq_32.h:11,
from /home/mingo/tip/arch/sparc/include/asm/irq.h:6,
from /home/mingo/tip/include/linux/irqnr.h:10,
from /home/mingo/tip/include/linux/irq.h:22,
from /home/mingo/tip/include/asm-generic/hardirq.h:6,
from /home/mingo/tip/arch/sparc/include/asm/hardirq_32.h:11,
from /home/mingo/tip/arch/sparc/include/asm/hardirq.h:6,
from /home/mingo/tip/include/linux/hardirq.h:10,
from /home/mingo/tip/include/linux/ftrace_event.h:7,
from /home/mingo/tip/include/trace/syscall.h:6,
from /home/mingo/tip/include/linux/syscalls.h:76,
from /home/mingo/tip/init/initramfs.c:9:
/home/mingo/tip/include/linux/interrupt.h: In function '__raise_softirq_irqoff':
/home/mingo/tip/include/linux/interrupt.h:414: error: implicit declaration of function 'local_softirq_pending'
/home/mingo/tip/include/linux/interrupt.h:414: error: lvalue required as left operand of assignment
make[2]: *** [init/initramfs.o] Error 1
make[2]: *** Waiting for unfinished jobs....
In file included from /home/mingo/tip/arch/sparc/include/asm/irq_32.h:11,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/