Re: [PATCH] spi/spi_s3c64xx: Move to subsys_initcall()

[Jassi Brar]

On Wed, Sep 8, 2010 at 6:12 PM, Mark Brown
<broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> On Wed, Sep 08, 2010 at 01:55:39PM +0900, Jassi Brar wrote:
>> On Tue, Sep 7, 2010 at 7:29 PM, Mark Brown
>> <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
>> > Allow the use of the S3C64xx SPI controller with things like PMICs by
>> > moving the init up to subsys_initcall().
>
>> Couldn't any user ever need to load it as a module?
>> If no, we might as well drop the s3c64xx_spi_exit and s3c64xx_spi_remove
>
> This doesn't prevent building as a module - when built as a module
> subsys_initcall() is identical to module_init(), the change will only
> affect the order in which things are done when the code is built into
> the kernel otherwise it's a noop.
I didn't know that, thanks for the info.

Acked-by: Jassi Brar <jassi.brar@xxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/