Re: [patch 27/30] staging: Bulk convert the semaphore mess

[Greg KH]

On Wed, Sep 08, 2010 at 10:59:23AM +0200, Thomas Gleixner wrote:
> On Tue, 7 Sep 2010, Greg KH wrote:
> 
> > On Tue, Sep 07, 2010 at 02:33:47PM -0000, Thomas Gleixner wrote:
> > > init_MUTEX(_LOCKED) and DECLARE_MUTEX are going away. Bulk convert
> > > staging users.
> > 
> > I don't think you actually built this change:
> > 
> > > --- linux-2.6.orig/drivers/staging/comedi/drivers/usbdux.c
> > > +++ linux-2.6/drivers/staging/comedi/drivers/usbdux.c
> > > @@ -315,7 +315,7 @@ struct usbduxsub {
> > >   */
> > >  static struct usbduxsub usbduxsub[NUMUSBDUX];
> > >  
> > > -static DECLARE_MUTEX(start_stop_sem);
> > > +static DEFINE_SEMAPHORE(start_stop_sem);
> > >  
> > >  /*
> > >   * Stops the data acquision
> > 
> > I don't see DEFINE_SEMAPHORE() in Linus's tree, what should we use
> > instead?
> 
> It's the first patch in the series, which I want to get Linus wards
> now, so this does not trip over.

Ah, that makes sense.

Well, it didn't hurt for me to take the other portions of this patch,
right?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/