[PATCH] netlink: Fix kfree NULL pointer

[jovi zhang]

It will kfree NULL pointer if listeners is NULL. fix it.

Signed-off-by: bookjovi@xxxxxxxxx
net/netlink/af_netlink.c | Â Â5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index 980fe4a..1c7bf48 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -1532,8 +1532,10 @@ netlink_kernel_create(struct net *net, int
unit, unsigned int groups,
   Âif (input)
       Ânlk_sk(sk)->netlink_rcv = input;

- Â Â Â if (netlink_insert(sk, net, 0))
+ Â Â Â if (netlink_insert(sk, net, 0)) {
+ Â Â Â Â Â Â Â kfree(listeners);
       Âgoto out_sock_release;
+ Â Â Â }

   Ânlk = nlk_sk(sk);
   Ânlk->flags |= NETLINK_KERNEL_SOCKET;
@@ -1553,7 +1555,6 @@ netlink_kernel_create(struct net *net, int unit,
unsigned int groups,
   Âreturn sk;

out_sock_release:
- Â Â Â kfree(listeners);
   Ânetlink_kernel_release(sk);
   Âreturn NULL;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/