Re: [PATCH 09/10] x86/VT-d: Make Intel VT-d IOMMU use IOMMU_INIT_* macros.

From: Tony Luck
Date: Tue Sep 07 2010 - 14:10:41 EST


On Thu, Aug 26, 2010 at 10:58 AM, Konrad Rzeszutek Wilk
<konrad.wilk@xxxxxxxxxx> wrote:
> We utilize the IOMMU_INIT macros to create this dependency:
...
>  drivers/pci/dmar.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/pci/dmar.c b/drivers/pci/dmar.c
> index 5fa64ea..4ef56a0 100644
> --- a/drivers/pci/dmar.c
> +++ b/drivers/pci/dmar.c
> @@ -36,6 +36,7 @@
>  #include <linux/tboot.h>
>  #include <linux/dmi.h>
>  #include <linux/slab.h>
> +#include <asm/iommu_table.h>

This breaks ia64 - since you didn't make an asm/iommu_table.h for it :-(

Just copying the x86 one led to complaints about pci_swiotlb_detect_4gb()
not being declared ... so I think I need a bit more of the same infrastructure
you made of x86.

Pointers & hints please?

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/