Re: [PATCH] lis3: Add axes module parameter for custom axis-mapping

[Takashi Iwai]

At Tue, 07 Sep 2010 17:54:58 +0200,
Ãric Piel wrote:
> 
> Op 07-09-10 16:44, Takashi Iwai schreef:
> :
> >> Wouldn't it be much cleaner if lis3_dev.ac was an array instead of a
> >> struct? I don't mind that it involves changing more line if it makes
> >> things more understandable.
> > 
> > OK, then it makes things easier.  The revised patch is below.
> Yes, I like it much better...
> 
> >  
> > +module_param_array_named(axes, lis3_dev.axis_map, int, NULL, 0644);
> > +MODULE_PARM_DESC(axes, "Axis-mapping for x,y,z directions");
> But now there is no check at all about the value being between 1 and 3,
> is there?
> I think it's still necessary to have a small function which checks for
> correct values, otherwise the user could read a bit anywhere in the memory.

Ah, right, it's accessing the array index.  This must be fixed indeed.
Another revised version below.


thanks,

Takashi

===