Re: [PATCH 14/14] kernel/: Removing undead ifdefCONFIG_DEBUG_LOCK_ALLOC

From: Paul E. McKenney
Date: Mon Sep 06 2010 - 12:14:13 EST


On Mon, Sep 06, 2010 at 04:37:12PM +0200, Christian Dietrich wrote:
> The CONFIG_DEBUG_LOCK_ALLOC ifdef isn't necessary at this point, because it is
> checked in an outer ifdef level already and has no effect here.

Good catch, queued!

Thanx, Paul

> Signed-off-by: Christian Dietrich <qy03fugy@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
> ---
> kernel/srcu.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/srcu.c b/kernel/srcu.c
> index 2980da3..c71e075 100644
> --- a/kernel/srcu.c
> +++ b/kernel/srcu.c
> @@ -46,11 +46,9 @@ static int init_srcu_struct_fields(struct srcu_struct *sp)
> int __init_srcu_struct(struct srcu_struct *sp, const char *name,
> struct lock_class_key *key)
> {
> -#ifdef CONFIG_DEBUG_LOCK_ALLOC
> /* Don't re-initialize a lock while it is held. */
> debug_check_no_locks_freed((void *)sp, sizeof(*sp));
> lockdep_init_map(&sp->dep_map, name, key, 0);
> -#endif /* #ifdef CONFIG_DEBUG_LOCK_ALLOC */
> return init_srcu_struct_fields(sp);
> }
> EXPORT_SYMBOL_GPL(__init_srcu_struct);
> --
> 1.7.0.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/