Re: [PATCH] KVM: don't sent IPI if the vcpu is not online

[Xiao Guangrong]

On 09/05/2010 03:18 PM, Avi Kivity wrote:
>  On 09/03/2010 07:12 AM, Xiao Guangrong wrote:
>> It's no need sent IPI to the vcpu which is schedule out
>>
>>
>> @@ -86,6 +86,7 @@ struct kvm_vcpu {
>>       unsigned long requests;
>>       unsigned long guest_debug;
>>       int srcu_idx;
>> +    bool online;
> 
> Why not check for guest_mode instead?
> 

Oh, i forget it...but 'vcpu->guest_mode' is only used in x86 platform,
and make_all_cpus_request() is a common function.

So, maybe it's better use 'vcpu->online' here, and move 'guest_mode' into
'vcpu->arch' ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/