Re: [alsa-devel] tlv320aic3x: potential null dereference

From: Jarkko Nikula
Date: Sun Sep 05 2010 - 11:45:57 EST


On Sat, 04 Sep 2010 15:07:57 +0200
Jiri Slaby <jirislaby@xxxxxxxxx> wrote:

> Hi,
>
> stanse found a potential null dereference:
> aic3x_i2c_probe
> -> struct aic3x_setup_data *setup = pdata->setup;
> -> -- pdata can't be null now--
> -> if (pdata && pdata->gpio_reset >= 0)
>
> But there is another check for pdata == NULL. Could take a look and fix
> it (either remove the check or move the assignement inside the if)?
>
Thanks, this is a bug that got introduced recently to ASoC tree.
Fortunately is not in mainline. I'll send a fix in a minute to
alsa-devel.


--
Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/