Re: [PATCH 0/6] overlay filesystem prototype

From: J. R. Okajima
Date: Sun Sep 05 2010 - 06:38:21 EST



Miklos Szeredi:
> Changes since the last version:
:::
> - get write ref on the upper layer on mount unless the overlay
> itself is mounted read-only

I think it a good approach.
Although it may be harmless, write-ref will not be put when a user
executes,
- mount -o ro /overlay
- umount /overlay
It will be easy to fix by implementing s_op->remount().


> - raise capabilities for copy up, dealing with whiteouts and opaque
> directories. Now the overlay works for non-root users as well

Interesting approach.
But is it safe? If multi-threaded ap or a signal handler share
the credential, then they may gain incorrect capability.


J. R. Okajima
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/