Re: [PATCH 2/3] M68K: Use CONFIG_MMU not __uClinux__ to select m68knommucontributions

[Greg Ungerer]

On 03/09/10 19:52, David Howells wrote:
> Geert Uytterhoeven<geert@xxxxxxxxxxxxxx>  wrote:
>
> > > Not sure about m68k but m68knommu targets already setup
> > > appropriate -mcpu flags for its various supported CPU types.
> >
> > Same for m68k.
>
> It doesn't seem to:
>
> 	warthog>grep -r mcpu arch/m68k
> 	warthog1>grep -r mtune arch/m68k
> 	warthog1>
>
> I see that m68knommu does:
>
> 	warthog1>grep -r mcpu arch/m68knommu/
> 	arch/m68knommu/Makefile:cflags-$(CONFIG_M5206)          := $(call cc-option,-mcpu=5206,-m5200)
> 	arch/m68knommu/Makefile:cflags-$(CONFIG_M520x)          := $(call cc-option,-mcpu=5208,-m5200)
> 	arch/m68knommu/Makefile:cflags-$(CONFIG_M523x)          := $(call cc-option,-mcpu=523x,-m5307)
> 	...
>
> I guess the m68k compiler I already had doesn't fully support -m5200, since I
> see that, but it doesn't compile some of the instructions when compiling the
> m68knommu defconfig (CONFIG_M520x=y).

Ah, ok, that would explain it. The m520x is one of the newer ColdFire
variants (thus proper cpu=5208 support is only in more recent binutils.
A fallback to -m5200 (which is the absolute minimum ColdFire support)
looks like it is not quite enough here.

Regards
Greg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/