Re: kernelshark plugins and ftrace array fields

From: Avi Kivity
Date: Thu Sep 02 2010 - 10:34:51 EST


On 09/02/2010 05:25 PM, Steven Rostedt wrote:
On Thu, 2010-09-02 at 15:19 +0300, Avi Kivity wrote:
I'd like to add enhance kvm_emulate_insn display in kernelshark to
show the disassembly of the instruction being emulated. However,
pevent_get_field_val() doesn't support arrays (the instruction is
provided in a 15-byte array).

Can you add support for arrays in the kernelshark API? With that, it
looks like adding disassembly output to the kvm plugin should be quite
simple.

Sure, I could add a pevent_get_field_array() or something. Could you
tell me the event and give me an example of what you want to do.

plugin_kvm.c:

kvm_emulate_insn_handler()
{
fetch insn array and len field
feed into disassembler
trace_seq_printf() the disassembled instruction
}

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/