Re: [RFC] jffs2: use cond_resched() instead of yield()

[Joakim Tjernlund]

>
> This 'yield()' was introduced by dwmw2, so he may have strong feelings
> about it. CCed.

Actually, it was introduced by me with commit fd5324909e410a3202c1b01bd507c2dfba58fca5 :

[JFFS2] Fix hanging close for /dev/mtd character device.

    When pdflush is erasing lots of sectors, drivers calling
    mtd->sync will hang until all blocks are erased. Be nicer.

    Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@xxxxxxxxxxxx>
    Signed-off-by: David Woodhouse <dwmw2@xxxxxxxxxxxxx>


@@ -142,7 +142,7 @@ void jffs2_erase_pending_blocks(struct jffs2_sb_info *c, int count)
 		}

 		/* Be nice */
-		cond_resched();
+		yield();
 		spin_lock(&c->erase_completion_lock);
 	}

At the time cond_resched() was a problem but now I don't know. The erasing
has moved to the GC thread and been somewhat reworked. I don't know if
it still needs yield(). Perhaps David can tell?

    Jocke
>
> On Wed, 2010-09-01 at 18:03 +0200, Wolfram Sang wrote:
> > yield() has different semantics meanwhile and even causes RT-kernels to
> > BUG. Replace the only appearance left in jffs2.
> >
> > Signed-off-by: Wolfram Sang <w.sang@xxxxxxxxxxxxxx>
> > Cc: Artem Bityutskiy <Artem.Bityutskiy@xxxxxxxxx>
> > Cc: Ingo Molnar <mingo@xxxxxxx>
> > ---
> >
> > The aforementioned BUG() showed up in one of our customer's RT-projects. While
> > this could be handled by rearranging his thread-priorities, I wondered if such
> > a patch would be worthwhile, still. Reading through the material covering
> > yield() and related replacements, I believe this patch should be appropriate.
> > Please say if I missed some side-effects.
> >
> >  fs/jffs2/erase.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/fs/jffs2/erase.c b/fs/jffs2/erase.c
> > index abac961..e513f19 100644
> > --- a/fs/jffs2/erase.c
> > +++ b/fs/jffs2/erase.c
> > @@ -151,7 +151,7 @@ int jffs2_erase_pending_blocks(struct jffs2_sb_info *c, int count)
> >        }
> >
> >        /* Be nice */
> > -      yield();
> > +      cond_resched();
> >        mutex_lock(&c->erase_free_sem);
> >        spin_lock(&c->erase_completion_lock);
> >     }
>
> --
> Best Regards,
> Artem Bityutskiy (Битюцкий Артём)
>
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/N▀╖╡ФЛr╦⌡yЗХ ьb╡X╛╤г╖vь^√;)ч╨{.nг+┴╥╔┼{╠▒ЙГzX╖╤⌡║э╗}╘·╡ф═zз&j:+v┴╗╬╚▒ЙГzZ+─й+zfё╒╥h ┬╖~├╜├шiЪШЮz╧╝w╔╒╦?≥╗Х╜з&╒)ъ╒f■Ы^jг╚y╖m┘А@A╚a╤зЪ0╤Лh╝Е▓i