Re: [PATCH 2/2] regulator: tps6586x-regulator - fix bit_mask parameterfor tps6586x_set_bits()

From: Mike Rapoport
Date: Mon Aug 23 2010 - 06:09:58 EST


Mark Brown wrote:
On Sun, Aug 22, 2010 at 10:42:42PM +0800, Axel Lin wrote:
The third parameter of tps6586x_set_bits() is the bit_mask,
thus we should use (1 << ri->go_bit) instead of ri->go_bit.

Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>

Acked-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>

but I'd be much happier if someone who actually has the hardware could
verify that this is OK.

I don't have the hardware handy at the moment.
Gary, can you please verify the fix?

--
Sincerely yours,
Mike.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/