Re: [PATCH] net: define __packed for the userspace code

From: David Miller
Date: Sun Aug 22 2010 - 22:36:17 EST


From: Changli Gao <xiaosuo@xxxxxxxxx>
Date: Mon, 23 Aug 2010 10:29:49 +0800

> Do you mean that use the __attribute__((packed)) annotation in all of
> these files:
>
> localhost linux # grep "\<__packed\>" usr/include/ -r | uniq
> usr/include/linux/if_hippi.h:} __packed;
> usr/include/linux/if_fddi.h:} __packed;
> usr/include/linux/nbd.h:} __packed;
> usr/include/linux/ncp.h:} __packed;
> usr/include/linux/rfkill.h:} __packed;
> usr/include/linux/if_pppox.h:} __packed;
> usr/include/linux/phonet.h:} __packed;
> usr/include/linux/ipv6.h:} __packed; /* required for some archs */
> usr/include/linux/ipv6.h:} __packed;
> usr/include/linux/if_ether.h:} __packed;

It seems so, yes.

There is no way that anybody has tried to compile anything in
userspace using these headers with the __packed usage there.

If they would, they would surely see a compile failure.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/