Re: [PATCH] firmware: fix request_firmware() error handling

[Greg KH]

On Sun, Aug 22, 2010 at 06:09:30PM +0300, Pekka Enberg wrote:
> If _request_firmware() fails and we do release_firmware(), update the pointer
> pointed to by 'firmware_p' so that we don't return a free'd pointer to the
> caller.
> 
> This patch fixes a boot-time crash on my MacBook that's caused by failing
> isight_firmware_load(). The bug was introduced in commit f8a4bd34 ("firmware
> loader: embed device into firmware_priv structure") and makes 2.6.36-rc1
> unusable on my box.
> 
> Cc: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> Signed-off-by: Pekka Enberg <penberg@xxxxxxxxxx>

Thanks, already in my tree and linux-next and will be going to Linus on
Monday.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/