Re: [tip:x86/urgent] x86, hwmon: Fix unsafe smp_processor_id() in thermal_throttle_add_dev

[Fenghua Yu]

On Fri, Aug 20, 2010 at 09:43:03PM -0700, tip-bot for Sergey Senozhatsky wrote:
> Commit-ID:  51e3c1b558b31b11bf5fc66d3c6f5adacf3573f7
> Gitweb:     http://git.kernel.org/tip/51e3c1b558b31b11bf5fc66d3c6f5adacf3573f7
> Author:     Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>
> AuthorDate: Fri, 20 Aug 2010 10:36:34 +0300
> Committer:  H. Peter Anvin <hpa@xxxxxxxxx>
> CommitDate: Fri, 20 Aug 2010 19:56:00 -0700
> 
> x86, hwmon: Fix unsafe smp_processor_id() in thermal_throttle_add_dev
> 
> Fix BUG: using smp_processor_id() in preemptible thermal_throttle_add_dev.
> We know the cpu number when calling thermal_throttle_add_dev, so we can
> remove smp_processor_id call in thermal_throttle_add_dev by supplying
> the cpu number as argument.
> 
> This should resolve kernel bugzilla 16615/16629.

The fix is right. Current thermal_throttle_add_dev checks local processor to
determine PTS and PLN features on another processor. Logically that is wrong.

Thanks.

-Fenghua
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/