RE: [RFC Patch] netxen: remove firmware exports

From: Amit Salecha
Date: Fri Aug 20 2010 - 04:54:13 EST


> Okay. David, do you want me to submit an updated patch?

You have to submit updated patch.

-Amit

> -----Original Message-----
> From: Cong Wang [mailto:amwang@xxxxxxxxxx]
> Sent: Friday, August 20, 2010 2:22 PM
> To: Amit Salecha
> Cc: linux-kernel@xxxxxxxxxxxxxxx; David S. Miller; Dhananjay Phadke;
> Narender Kumar; netdev@xxxxxxxxxxxxxxx
> Subject: Re: [RFC Patch] netxen: remove firmware exports
>
> On 08/19/10 17:12, Amit Salecha wrote:
> >> netxen_nic driver can store firmwares on flash, and get them
> porperly and
> >> dynamically, so the firmwares may not appear in /lib/firmware/.
> However, netxen_nic
> >> still exports these firmwares via modinfo, this makes our script
> which parses
> >> modinfo output fail.
> >
> > NX_UNIFIED_ROMIMAGE_NAME(phanfw.bin) is already submitted and we
> won't submit any other fw files.
> >
> >> -MODULE_FIRMWARE(NX_P2_MN_ROMIMAGE_NAME);
> >> -MODULE_FIRMWARE(NX_P3_CT_ROMIMAGE_NAME);
> >> -MODULE_FIRMWARE(NX_P3_MN_ROMIMAGE_NAME);
> >
> > It's not compulsory to submit firmware files which are exported
> (MODULE_FIRMWARE).
> > I am leaving this upto David to decide about this patch.
> >
>
> Okay. David, do you want me to submit an updated patch?
>
> Thanks!
>
> --
> The opposite of love is not hate, it's indifference.
> - Elie Wiesel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/