Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_PHUB driver to 2.6.35

[Masayuki Ohtake]

----- Original Message ----- 
From: "Greg KH" <gregkh@xxxxxxx>
To: "Masayuki Ohtake" <masa-korg@xxxxxxxxxxxxxxx>
Cc: <meego-dev@xxxxxxxxx>; "LKML" <linux-kernel@xxxxxxxxxxxxxxx>; <yong.y.wang@xxxxxxxxx>; <qi.wang@xxxxxxxxx>;
<andrew.chih.howe.khor@xxxxxxxxx>; <arjan@xxxxxxxxxxxxxxx>; <alan@xxxxxxxxxxxxxxx>; <margie.foster@xxxxxxxxx>
Sent: Friday, August 20, 2010 12:17 AM
Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_PHUB driver to 2.6.35


> On Thu, Aug 19, 2010 at 03:27:23PM +0900, Masayuki Ohtake wrote:
> > Hi Greg,
> >
> > Thank you for your comments.
> > > > +#define MODULE_NAME "pch_phub"
> > >
> > > This isn't needed, right?  The kernel provides this to you in the build
> > > service automatically.
> >
> > I can't understand above enough.
> > Is the above mean  like below ?
> >
> > * Delete the following line.
> > > > +#define MODULE_NAME "pch_phub"
> >
> >  * Modify the following line(Use "pch_phub" directly)
> > > > + ret = pci_request_regions(pdev, "pch_phub");
>
> No, use the variable that the build system provides to you,
> KBUILD_MODNAME

I understand.

Thanks, Ohtake(OKISEMI)

>
> thanks,
>
> greg k-h
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/