Re: struct fanotify_event_metadata

[Tvrtko Ursulin]

On Saturday 14 Aug 2010 18:44:38 Andreas Schwab wrote:
> The pid field of struct fanotify_event_metadata has 64 bits which looks
> excessive.  Wouldn't it make sense to make it 32 bits and swap it with
> the mask field?  That would avoid the unaligned mask field, and remove
> the need for the packed attribute.

No one seems to have picked up on this what I thought was an obvious good
idea.

So yes, 32-bit PID makes sense I think. If that was changed, would removing
the packed attribute get us anything more? If not it may stay for extra safety
if/when new fields are added.

Also, would it make sense to move mask in front of fd so 32-bit pid can stay
at the end? I think mask logically should be higher because is the more meta
data, while pid is auxiliary.

Tvrtko

Sophos Plc, The Pentagon, Abingdon Science Park, Abingdon, OX14 3YP, United Kingdom.
Company Reg No 2096520. VAT Reg No GB 348 3873 20.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/