Re: [PATCH] perf tools: Fix build error on read only source.

From: Arnaldo Carvalho de Melo
Date: Thu Aug 19 2010 - 10:13:52 EST


Em Thu, Aug 19, 2010 at 12:31:48PM +0200, Bernd Petrovitsch escreveu:
> On Mit, 2010-08-18 at 14:19 -0300, Arnaldo Carvalho de Melo wrote:
> > Em Wed, Aug 18, 2010 at 05:25:41PM +0200, Bernd Petrovitsch escreveu:
> > > On Mit, 2010-08-18 at 11:14 -0300, Arnaldo Carvalho de Melo wrote:
> [...]
> > > > $(phony feature-tests):
> > > First, this should probably have been:
> > > .PHONY: feature-tests
> >
> > Humm, isn't $(phony feature-tests): variation valid and shorter, humm,
> > yeah, seems to be for !GNU make :-\
> >
> > (http://makepp.sourceforge.net/1.18/t_phony.html)
>
> Funny, I didn't knew GNU-make's "$(phony target): " construct.

it doesn't have AFAIK, its just this makepp, that I never had heard
about before, that has it, probably it introduced the idea. Quite
sensible, it seems.

> Hmm, what GNU-make versions and other `make`s are considered (or should
> be) supported?

I think only GNU make is supported.

> [...]
> > There is no use of mktemp in Kbuild, that I try hard to use as reference
> > here.
>
> FWIW fine with me - I just threw an idea in.

Right, and I considered it, using Kbuild usage as a validation gauge to
say we probably shouldn't use it :)

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/